virajjasani commented on a change in pull request #1914:
URL: https://github.com/apache/hbase/pull/1914#discussion_r442079714
##########
File path: bin/hbase-config.sh
##########
@@ -94,6 +94,10 @@ do
shift
# shellcheck disable=SC2034
DEBUG="true"
+ elif [ "--help" = "$1" ] || [ "-h" = "$1" ]
+ then
+ echo "Error usage! You should use it like 'hbase --help' or 'hbase -h'";
Review comment:
Got it, yeah user should not provide `--help` with `--config` or any
other argument. This error handling is definitely helpful. Thanks @WenFeiYi .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
