ndimiduk commented on a change in pull request #1782:
URL: https://github.com/apache/hbase/pull/1782#discussion_r442360729
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java
##########
@@ -114,4 +115,12 @@ static RSGroupInfoManager create(MasterServices master)
throws IOException {
*/
void renameRSGroup(String oldName, String newName) throws IOException;
+ /**
+ * Update RSGroup configuration
+ * @param groupName the group name
+ * @param configuration new configuration of the group name to be set
+ * @throws IOException if a remote or network exception occurs
+ */
+ void updateRSGroupConfig(String groupName, Map<String, String>
configuration) throws IOException;
+
Review comment:
Similar question about the interface allowing deeper access to the map.
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
##########
@@ -114,6 +120,14 @@ public boolean removeServer(Address hostPort) {
return servers.remove(hostPort);
}
+ public Map<String, String> getConfiguration() {
+ return configuration;
+ }
+
+ public void setConfiguration(Map<String, String> configuration) {
+ this.configuration = configuration;
+ }
+
Review comment:
`TableDescriptor` and `ColumnFamiltyDescriptor` have a similar
requirement, but provide a richer interface for interacting with their maps.
Consider providing similar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
