[
https://issues.apache.org/jira/browse/HBASE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263194#comment-13263194
]
Jonathan Hsieh commented on HBASE-5801:
---------------------------------------
Hey Jimmy, code looks good, I found a few typos, will fix before commit.
Typos: are -> is ; multipe -> multiple
{code}
+ LOG.warn("Region " + hbi.toString() + " are deployed on multiple
region servers."
+ + " Please fix the multiple assignments before fixing multipe
table desc.");
{code}
Remove @param / @praam / @throws (or fill them in).
{code}
+ * Replace the .regioninfo with a new one with the expected table desc,
+ * then re-assign the region.
+ *
+ * @param admin
+ * @praam hsa
+ * @param hbi
+ * @param htd
+ * @param sidelineTableDir
+ * @throws IOException
+ * @throws KeeperException
+ * @throws InterruptedException
+
{code}
typo: regioninfoSidelinPath -> regioninfoSidelinePath
{code}
+ Path regioninfoSidelinPath = new Path(sidelineRegionDir,
HRegion.REGIONINFO_FILE);
{code}
> [hbck] Hbck should handle case where some regions have different HTD settings
> in .regioninfo files (0.90 specific)
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5801
> URL: https://issues.apache.org/jira/browse/HBASE-5801
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.7
> Reporter: Jonathan Hsieh
> Assignee: Jimmy Xiang
> Fix For: 0.90.7
>
> Attachments: hbase_5801_v2.patch, hbase_5801_v3.patch
>
>
> Recently, we encountered a case where some regions in a table have different
> HTableDescriptor settings serialized into HDFS their HRegionInfo .regioninfo
> file. hbck expects all HTDs within a table to be the same and currently
> bails out in this situation.
> We need to either point out a proper set of actions for the user to execute
> or automatically convert the region to a common HTD (likely the most common
> on, or possibly the "first one".)
> Not sure if this requires reformatting data but may require closing and
> restarting a region.
> This issue is hbase 0.90.x specific -- 0.92+ keep all table info in a single
> .tableinfo file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
