brfrn169 commented on a change in pull request #1938:
URL: https://github.com/apache/hbase/pull/1938#discussion_r443174131
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java
##########
@@ -590,7 +590,9 @@ public static void buildNoDataRegionActions(final byte[]
regionName,
if (!multiRequestBuilder.hasNonceGroup() && hasNonce) {
multiRequestBuilder.setNonceGroup(nonceGroup);
}
- multiRequestBuilder.addRegionAction(builder.build());
+ if (builder.getActionCount() > 0) {
Review comment:
Thank you for taking a look at this!
Actually the server side does nothing as the RegionAction is empty. So I'd
say it's not a critical bug. It will just waste network traffic a bit I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]