Apache9 commented on a change in pull request #1782:
URL: https://github.com/apache/hbase/pull/1782#discussion_r443290366
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java
##########
@@ -114,6 +121,34 @@ public boolean removeServer(Address hostPort) {
return servers.remove(hostPort);
}
+ /**
+ * Getter for fetching an unmodifiable {@link #configuration} map.
+ */
+ public Map<String, String> getConfiguration() {
+ // shallow pointer copy
+ return Collections.unmodifiableMap(configuration);
+ }
+
+ /**
+ * Setter for storing a configuration setting in {@link #configuration} map.
+ * @param key Config key.
+ * @param value String value. If null, removes the setting.
+ */
+ public void setConfiguration(String key, String value) {
Review comment:
Oh, you can just use Objects.requireNonNull. I see there is still a null
check so do not look closely the line inside the if...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
