ndimiduk commented on a change in pull request #1933:
URL: https://github.com/apache/hbase/pull/1933#discussion_r443804878
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -1304,8 +1304,8 @@ private void checkAndGetTableName(byte[]
encodeRegionName, AtomicReference<Table
}
addListener(
- this.<MergeTableRegionsRequest, MergeTableRegionsResponse>
procedureCall(tableName, request,
- (s, c, req, done) -> s.mergeTableRegions(c, req, done), (resp) ->
resp.getProcId(),
+ this.procedureCall(tableName, request,
+ MasterService.Interface::mergeTableRegions,
MergeTableRegionsResponse::getProcId,
Review comment:
yes please for method references, 👍
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -473,6 +473,10 @@ public void run() {
// Cached clusterId on stand by masters to serve clusterID requests from
clients.
private final CachedClusterId cachedClusterId;
+ // Split/Merge Normalization plan executes asynchronously and the caller
blocks on
+ // waiting max 5 sec for single plan to complete with success/failure.
+ private static final int NORMALIZATION_PLAN_WAIT_TIMEOUT = 5;
Review comment:
I'm still not convinced we should do this, per my other comment :)
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -473,6 +473,10 @@ public void run() {
// Cached clusterId on stand by masters to serve clusterID requests from
clients.
private final CachedClusterId cachedClusterId;
+ // Split/Merge Normalization plan executes asynchronously and the caller
blocks on
+ // waiting max 5 sec for single plan to complete with success/failure.
+ private static final int NORMALIZATION_PLAN_WAIT_TIMEOUT = 5;
Review comment:
nit: i like to include a unit in these types of constants. i.e.,
`NORMALIZATION_PLAN_WAIT_TIMEOUT_SEC`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
