anoopsjohn commented on a change in pull request #1955:
URL: https://github.com/apache/hbase/pull/1955#discussion_r443967906
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java
##########
@@ -191,50 +186,22 @@ public boolean keepRegionEvent(Entry entry) {
return false;
}
+ /**
+ * @return Returns a base HFile without compressions or encodings; good
enough for recovery
Review comment:
In Jira, I added a comment about making sure we will compact all these
tiny HFiles created as part of WAL split. If we can make sure that part, I
would say it ok to create these tiny files with out any table specific things
like compression/DBE etc. Anyways we know all these files are going to get
compacted and rewritten once we open the region.
As of now we are not sure whether or when these tiny files will get
compacted. In such case I would +1 ur ask. Do this HFile create with defaults
as a fall back only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
