bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649242923
> The flag is set when we are in a critical condition -- the WAL count is in excess of our WAL limit. The flag's intent IIRC is that we flush all stores regardless of what determination is made at flush time as to which stores are in need of flush or not; the old edit may actually be hanging out in a store that is small and not in need of flush normally or in accordance w/ some flush policy. The flag says 'force' the flus. My understanding is that this is a FlushRequest usually but the flag changes the request to a demand. > > Here you are passing a set of stores. Will these be flushed regardless when we go to flush? The flush policy won't prevent one or two of these stores being flushed? At a minimum I'd think this flag would change meaning from 'force flush all stores' to 'force flush these passed stores' if we are being passed the families whos flush will allow us clear WALs, or if null families, 'force flush all stores'. > > If the 'force' of a flush is not needed, then we should purge this flag altogether as it confuses? > > I'm unsure of what you intend here. This is an important trigger and you seem to be undoing it. Pardon me if I'm not following properly. Yeah, i am agree with you, maybe the forceFlushAllStores should be enum, named selectType that include "FORCE_ALL","FORCE_WITH_SPECIFIED","FLUSH_POLICY"? And it is a long story yet, i can do it in follow-on jira, WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
