apurtell commented on a change in pull request #1945:
URL: https://github.com/apache/hbase/pull/1945#discussion_r445736122
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java
##########
@@ -530,10 +539,26 @@ public void process(WatchedEvent event) {
break;
}
default:
- throw new IllegalStateException("Received event is not valid: " +
event.getState());
+ LOG.error("Invalid event of type {} received for path {}. Ignoring.",
+ event.getState(), event.getPath());
}
}
+ /**
+ * Method called from ZooKeeper for events and connection status.
+ * <p>
+ * Valid events are passed along to listeners. Connection status changes
+ * are dealt with locally.
+ */
+ @Override
+ public void process(WatchedEvent event) {
+ LOG.debug(prefix("Received ZooKeeper Event, " +
+ "type=" + event.getType() + ", " +
+ "state=" + event.getState() + ", " +
+ "path=" + event.getPath()));
+ zkEventProcessor.submit(() -> processEvent(event));
Review comment:
Do we need the lambda here? branch-1....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
