ndimiduk commented on a change in pull request #1933:
URL: https://github.com/apache/hbase/pull/1933#discussion_r445191420
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -833,6 +833,9 @@ void unassign(byte[] regionName, boolean force)
/**
* Invoke region normalizer. Can NOT run for various reasons. Check logs.
+ * This is a non-blocking invocation to region normalizer. If return value
is true, it means
+ * the invocation was successful. We need to check logs for the details of
which regions
Review comment:
nit: "means the request was submitted successfully."
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/EmptyNormalizationPlan.java
##########
@@ -44,7 +44,8 @@ public static EmptyNormalizationPlan getInstance(){
* No-op for empty plan.
*/
@Override
- public void execute(Admin admin) {
+ public long submit(MasterServices masterServices) throws IOException {
+ return -1;
Review comment:
@huaxiangsun does the pid `-1` carry a special meaning? Just in case...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
