[GitHub] [hbase] comnetwork commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

[GitBox]

comnetwork commented on a change in pull request #1970:
URL: https://github.com/apache/hbase/pull/1970#discussion_r445943229



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
##########
@@ -46,6 +46,10 @@
 
   protected FSDataOutputStream output;
 
+  private volatile long syncedLength = 0;

Review comment:
       seems that using AtomicLong is unnecessary, because AtomicLong could not 
provide `update if greater than` semantics,  so I used `synchronized` keyword 
here when updating the syncedLength for simplicity




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org