Apache9 commented on a change in pull request #1990:
URL: https://github.com/apache/hbase/pull/1990#discussion_r446810099
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
##########
@@ -1837,35 +1837,30 @@ public GetOnlineRegionResponse getOnlineRegion(final
RpcController controller,
@Override
@QosPriority(priority=HConstants.ADMIN_QOS)
public GetRegionInfoResponse getRegionInfo(final RpcController controller,
- final GetRegionInfoRequest request) throws ServiceException {
+ final GetRegionInfoRequest request) throws ServiceException {
try {
checkOpen();
requestCount.increment();
HRegion region = getRegion(request.getRegion());
RegionInfo info = region.getRegionInfo();
- byte[] bestSplitRow = null;
- boolean shouldSplit = true;
+ byte[] bestSplitRow;
if (request.hasBestSplitRow() && request.getBestSplitRow()) {
- HRegion r = region;
- region.startRegionOperation(Operation.SPLIT_REGION);
- r.forceSplit(null);
- // Even after setting force split if split policy says no to split
then we should not split.
- shouldSplit = region.getSplitPolicy().shouldSplit() &&
!info.isMetaRegion();
Review comment:
Changed getSplitPolicy to package private and added a VisibleForTesting
annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
