[
https://issues.apache.org/jira/browse/HBASE-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264415#comment-13264415
]
Zhihong Yu commented on HBASE-5342:
-----------------------------------
I got the following when applying the draft patch:
{code}
2 out of 9 hunks FAILED -- saving rejects to file
security/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java.rej
{code}
{code}
+ private void updateGlobalCache(ListMultimap<String,TablePermission>
userPerms) {
{code}
I would expect Permission in the method signature above. Can the following
method be changed to return ListMultimap<String, Permission> ?
{code}
ListMultimap<String,TablePermission> perms =
AccessControlLists.readPermissions(in, conf);
{code}
{code}
- Set<String> tableSet = new HashSet<String>();
+ Set<byte[]> tableSet = new HashSet<byte[]>();
{code}
HashSet is backed by HashMap: see line 93 of
http://www.docjar.com/html/api/java/util/HashSet.java.html
I think a proper comparator should be used above.
{code}
+ * Returns true if this permission describe a user global permission.
{code}
Should read 'describes a global user permission'
{code}
+ raise(ArgumentError, "Can't find a family: #{family}") unless
htd.hasFamily(family.to_java_bytes)
{code}
Line exceeds 100 chars. Remove the 'a' before 'family' or replace it with 'the'.
{code}
+ user_permission =
org.apache.hadoop.hbase.security.access.UserPermission.new(user.to_java_bytes,
table_name.to_java_bytes, fambytes, qualbytes, "".to_java_bytes)
{code}
Above line is too long. Length should be no longer than 100 chars. Same with
the assignment in the else block below.
> Grant/Revoke global permissions
> -------------------------------
>
> Key: HBASE-5342
> URL: https://issues.apache.org/jira/browse/HBASE-5342
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Matteo Bertozzi
> Attachments: HBASE-5342-draft.patch
>
>
> HBASE-3025 introduced simple ACLs based on coprocessors. It defines
> global/table/cf/cq level permissions. However, there is no way to
> grant/revoke global level permissions, other than the hbase.superuser conf
> setting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
