ndimiduk commented on a change in pull request #2001:
URL: https://github.com/apache/hbase/pull/2001#discussion_r449284181
##########
File path: dev-support/create-release/release-util.sh
##########
@@ -236,6 +236,14 @@ function get_release_info {
GIT_EMAIL="[email protected]"
GPG_KEY="$(read_config "GPG_KEY" "$GIT_EMAIL")"
+ if ! GPG_KEY_ID=$("${GPG}" "${GPG_ARGS[@]}" --keyid-format 0xshort
--list-public-key "${GPG_KEY}" | grep "\[S\]" | grep -o "0x[0-9A-F]*") ||
+ [ -z "${GPG_KEY_ID}" ] ; then
+ GPG_KEY_ID=$("${GPG}" "${GPG_ARGS[@]}" --keyid-format 0xshort
--list-public-key "${GPG_KEY}" | head -n 1 | grep -o "0x[0-9A-F]*" || true)
+ fi
+ read -r -p "We think the key '${GPG_KEY}' corresponds to the key id
'${GPG_KEY_ID}'. Is this correct [y/n? " ANSWER
Review comment:
missing closing brace on `[y/n?`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
