brfrn169 commented on a change in pull request #1991:
URL: https://github.com/apache/hbase/pull/1991#discussion_r449854459
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTableImpl.java
##########
@@ -497,7 +497,7 @@ public void run(MultiResponse resp) {
"Failed to mutate row: " +
Bytes.toStringBinary(mutation.getRow()), ex));
} else {
future.complete(respConverter
- .apply((Result)
multiResp.getResults().get(regionName).result.get(0)));
+ .apply((RES)
multiResp.getResults().get(regionName).result.get(0)));
Review comment:
Yes, correct. Previously, we returned only Result type but after this
fix, we will return Result (for normal mutateRow) and CheckAndMutateResult (for
checkAndMutate). So I used a generic type here.
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableOverAsyncTable.java
##########
@@ -300,13 +300,16 @@ public boolean thenMutate(RowMutations mutation) throws
IOException {
}
@Override
- public boolean checkAndMutate(CheckAndMutate checkAndMutate) throws
IOException {
+ public CheckAndMutateResult checkAndMutate(CheckAndMutate checkAndMutate)
throws IOException {
return FutureUtils.get(table.checkAndMutate(checkAndMutate));
}
@Override
- public boolean[] checkAndMutate(List<CheckAndMutate> checkAndMutates) throws
IOException {
- return
Booleans.toArray(FutureUtils.get(table.checkAndMutateAll(checkAndMutates)));
+ public CheckAndMutateResult[] checkAndMutate(List<CheckAndMutate>
checkAndMutates)
Review comment:
Yeah that's better. I will change it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
