Apache9 commented on a change in pull request #1970:
URL: https://github.com/apache/hbase/pull/1970#discussion_r450569339
##########
File path:
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java
##########
@@ -91,7 +93,11 @@ private void flush0(CompletableFuture<Long> future,
ByteArrayOutputStream buffer
out.hflush();
}
}
- future.complete(out.getPos());
+ long pos = out.getPos();
+ if(pos > this.syncedLength) {
+ this.syncedLength = pos;
Review comment:
This one is just for test so not a big problem but aligning with other
producation implementations is better. Can have an addendum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
