anoopsjohn commented on a change in pull request #2021:
URL: https://github.com/apache/hbase/pull/2021#discussion_r451688123
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##########
@@ -148,10 +148,9 @@ private void abort(String reason, Throwable cause) {
@Override
public void run() {
while (running) {
- boolean periodic = false;
long now = System.currentTimeMillis();
checkLowReplication(now);
- periodic = (now - this.lastRollTime) > this.rollPeriod;
+ boolean periodic = (now - this.lastRollTime) > this.rollPeriod;
Review comment:
Not on this patch directly.
We have the periodic WAL roll.. Every WAL should get rolled as per this
period. When one WAL gets rolled, we will change the lastRollTime and so it
can happen that some WALs will ever get rolled!
This issue will be visible now as we will selectively roll WAL files after
this patch. Actually we need to track the lastRollTime per WAL instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
