wchevreuil commented on pull request #2032: URL: https://github.com/apache/hbase/pull/2032#issuecomment-656782840
> The javadoc issues also exist in master, is this a bug of jdk11? See https://bugs.openjdk.java.net/browse/JDK-8212233. > > There is a workaround in project commons-pool, can we do as same way? > https://github.com/apache/commons-pool/blob/master/pom.xml > > ``` > <profile> > <id>java11+</id> > <activation> > <jdk>[11,)</jdk> > </activation> > <properties> > <!-- Workaround for https://bugs.openjdk.java.net/browse/JDK-8212233 > which causes javadoc to fail with "javadoc: error - The code being documented uses modules > but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module." --> > <maven.javadoc.skip>true</maven.javadoc.skip> > </properties> > </profile> > ``` > > Thanks. @wchevreuil No, let's leave as it is. Am going to merge it now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
