ndimiduk commented on a change in pull request #2017:
URL: https://github.com/apache/hbase/pull/2017#discussion_r452996830
##########
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
##########
@@ -1842,7 +1842,7 @@ private void
countDownChildren(RootProcedureState<TEnvironment> procStack,
store.update(parent);
scheduler.addFront(parent);
LOG.info("Finished subprocedure pid={}, resume processing parent {}",
- procedure.getProcId(), parent);
+ procedure.getProcId(), parent.toString().replace("pid=","ppid="));
Review comment:
Other attributes of the parent should be available via earlier log
lines; the operator can search for that `pid=` in the same log.
I still don't like doing a string replace on the output of another class's
`toString` method. A format string like `info("... resume processing parent
({})", parent);` works as a compromise for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
