nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-657186954
> I wonder do we still need the testSizes method in TestHeapSize after this change? And we need a performance test to see if there are any impact on performance(although I believe no) Yes, this change only affect class loading phase. And the calculation of FIXED_OVERHEAD cost less than 5 milliseconds ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
