[
https://issues.apache.org/jira/browse/HBASE-5900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264934#comment-13264934
]
Zhihong Yu commented on HBASE-5900:
-----------------------------------
Please keep the original indentation so that it is easy to see the changes:
{code}
+
+ public static final long HREGION_CLASS_SIZE = ClassSize.OBJECT
+ + ClassSize.ARRAY + 31 * ClassSize.REFERENCE + Bytes.SIZEOF_INT
+ + (5 * Bytes.SIZEOF_LONG) + Bytes.SIZEOF_BOOLEAN;
- public static final long FIXED_OVERHEAD = ClassSize.align(
- ClassSize.OBJECT +
- ClassSize.ARRAY +
- 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
- (6 * Bytes.SIZEOF_LONG) +
- Bytes.SIZEOF_BOOLEAN);
{code}
I ran TestHeapSize with the patch and it passed.
Let's keep the patch in minimal form with the fix to FIXED_OVERHEAD only.
> HRegion#FIXED_OVERHEAD is miscalculated in 94.
> ----------------------------------------------
>
> Key: HBASE-5900
> URL: https://issues.apache.org/jira/browse/HBASE-5900
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Affects Versions: 0.94.0
> Reporter: Jieshan Bean
> Assignee: Jieshan Bean
> Fix For: 0.94.1
>
> Attachments: HRegion-FIEED_OVERHEAD.patch
>
>
> After apply the patch of HBASE-5611, and tested on a 32-bit machine. This
> problem was triggered.
> Before this patch, TestHeapSize is passed by pure coincidence in 94.
> {noformat}
> public static final long FIXED_OVERHEAD = ClassSize.align(
> ClassSize.OBJECT +
> ClassSize.ARRAY +
> 30 * ClassSize.REFERENCE + Bytes.SIZEOF_INT +
> (6 * Bytes.SIZEOF_LONG) +
> Bytes.SIZEOF_BOOLEAN);
> {noformat}
> Actually, there are 31 REFERENCEs and 5 LONGs in HRegion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
