[
https://issues.apache.org/jira/browse/HBASE-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264988#comment-13264988
]
Zhihong Yu commented on HBASE-5903:
-----------------------------------
Minor comments:
{code}
+/**
+ * Copyright 2012 The Apache Software Foundation
{code}
Year is not needed.
{code}
+ List<Class<?>> badClasses = new java.util.ArrayList<Class<?>>();
{code}
ArrayList is imported already.
{code}
+ private boolean existCategoryAnnotation(Class<?> c) {
{code}
Should the above method be named 'hasCategoryAnnotation()' ?
> Detect the test classes without categories
> ------------------------------------------
>
> Key: HBASE-5903
> URL: https://issues.apache.org/jira/browse/HBASE-5903
> Project: HBase
> Issue Type: Improvement
> Components: build, test
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 5903.v3.patch
>
>
> The tests are executed by category. When a test does not have a category,
> it's not run on prebuild nor central build.
> This new test checks the test classess and list the ones without category. It
> fails if it finds one. As it's a small test it will be executed on the
> developper machine and will fail immediately on the central builds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
