shahrs87 commented on a change in pull request #1962:
URL: https://github.com/apache/hbase/pull/1962#discussion_r454507461
##########
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableRangeHistogram.java
##########
@@ -80,7 +80,7 @@ public void updateSnapshotRangeMetrics(MetricsRecordBuilder
metricsRecordBuilder
long val = snapshot.getCount();
if (val - cumNum > 0) {
metricsRecordBuilder.addCounter(
- Interns.info(name + "_" + rangeType + "_" + ranges[ranges.length -
1] + "-inf", desc),
+ Interns.info(name + "_" + rangeType + "_" + priorRange + "-inf",
desc),
Review comment:
> Is it possible that ranges[] can be empty?
No. It is hardcoded in
https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableSizeHistogram.java#L31
and
https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableTimeHistogram.java#L31
##########
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableRangeHistogram.java
##########
@@ -80,7 +80,7 @@ public void updateSnapshotRangeMetrics(MetricsRecordBuilder
metricsRecordBuilder
long val = snapshot.getCount();
if (val - cumNum > 0) {
metricsRecordBuilder.addCounter(
- Interns.info(name + "_" + rangeType + "_" + ranges[ranges.length -
1] + "-inf", desc),
+ Interns.info(name + "_" + rangeType + "_" + priorRange + "-inf",
desc),
Review comment:
> Is it possible that ranges[] can be empty?
No. It is hardcoded in
https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableSizeHistogram.java#L31
and
https://github.com/apache/hbase/blob/master/hbase-hadoop-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableTimeHistogram.java#L31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
