ndimiduk commented on a change in pull request #2037:
URL: https://github.com/apache/hbase/pull/2037#discussion_r454671159
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/tool/CanaryTool.java
##########
@@ -128,14 +124,8 @@
public class CanaryTool implements Tool, Canary {
public static final String HBASE_CANARY_INFO_PORT = "hbase.canary.info.port";
- public static final int DEFAULT_CANARY_INFOPORT = 16050;
-
- public static final String HBASE_CANARY_INFO_BINDADDRESS =
"hbase.canary.info.bindAddress";
Review comment:
I think it's fine to remove these constants, at least to make them
private. Anyway, I see no reason for them to be public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
