[
https://issues.apache.org/jira/browse/HBASE-5785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265069#comment-13265069
]
jirapos...@reviews.apache.org commented on HBASE-5785:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4936/
-----------------------------------------------------------
Review request for hbase and Michael Stack.
Summary
-------
I added some tests for that conversion methods. For those helper utilities,
they are tested in other tests implicitly. We can add more later on if needed.
This addresses bug HBASE-5785.
https://issues.apache.org/jira/browse/HBASE-5785
Diffs
-----
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 9b594aa
src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java
PRE-CREATION
Diff: https://reviews.apache.org/r/4936/diff
Testing
-------
The new tests are green.
Thanks,
Jimmy
> Adding unit tests for protbuf utils introduced for HRegionInterface pb
> conversion
> ---------------------------------------------------------------------------------
>
> Key: HBASE-5785
> URL: https://issues.apache.org/jira/browse/HBASE-5785
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Priority: Critical
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: hbase-5785.patch
>
>
> We need to add some unit tests for the probuf utilities to catch issues
> earlier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
