[
https://issues.apache.org/jira/browse/HBASE-24742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157890#comment-17157890
]
Lars Hofhansl commented on HBASE-24742:
---------------------------------------
[~zhangduo] I'm with you there. The second part was harder to reason about, and
I feel a bit less easy about it.
In the end it's an optimization to save a comparison, previousIndexedKey and
nextIndexedKey will never accidentally be the same (as in identical), so I
*think* it should OK.
I'm not sure how we can avoid passing the fake keys up, since it is designed to
handle things and the "upper" heap. At least not without a lot refactoring.
[~apurtell] I'll take a look at HBASE-24637 (I'm a bit thinly spread, though)
> Improve performance of SKIP vs SEEK logic
> -----------------------------------------
>
> Key: HBASE-24742
> URL: https://issues.apache.org/jira/browse/HBASE-24742
> Project: HBase
> Issue Type: Bug
> Components: Performance, regionserver
> Affects Versions: 3.0.0-alpha-1, 1.7.0, 2.4.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Major
> Attachments: hbase-1.6-regression-flame-graph.png,
> hbase-24742-branch-1.txt
>
>
> In our testing of HBase 1.3 against the current tip of branch-1 we saw a 30%
> slowdown in scanning scenarios.
> We tracked it back to HBASE-17958 and HBASE-19863.
> Both add comparisons to one of the tightest HBase has.
> [~bharathv]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
