bharathv commented on a change in pull request #2064:
URL: https://github.com/apache/hbase/pull/2064#discussion_r455459283
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##########
@@ -926,7 +799,8 @@ public void join() {
* @return list of all normal sources
*/
public List<ReplicationSourceInterface> getSources() {
- return new ArrayList<>(this.sources.values());
+ return this.sources.values().stream().filter(source ->
source.isSourceActive())
Review comment:
ok
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -139,17 +144,16 @@
* Instantiation method used by region servers
* @param conf configuration to use
* @param fs file system to use
- * @param manager replication manager to ping to
* @param server the server for this region server
* @param queueId the id of our replication queue
* @param clusterId unique UUID for the cluster
* @param metrics metrics for replication source
*/
@Override
- public void init(Configuration conf, FileSystem fs, ReplicationSourceManager
manager,
+ public void init(Configuration conf, FileSystem fs, Path walDir,
ReplicationSourceManager manager,
Review comment:
Oh, I see, didn't realize you didn't change the recovered source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
