arshadmohammad commented on a change in pull request #2053:
URL: https://github.com/apache/hbase/pull/2053#discussion_r457230370
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -726,9 +726,14 @@ private void updateCacheOfRSGroups(final Set<String>
currentGroups) {
// Called by ServerEventsListenerThread. Presume it has lock on this manager
when it runs.
private SortedSet<Address> getDefaultServers() {
+ return getDefaultServers(listRSGroups()/* get from rsGroupMap */);
+ }
+
+ // Called by ServerEventsListenerThread. Presume it has lock on this manager
when it runs.
Review comment:
right, comment is not relevant on getDefaultServers(List<RSGroupInfo>
rsGroupInfoList) method.
but this PR is already merged. shall i create new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
