z-york commented on pull request #2113: URL: https://github.com/apache/hbase/pull/2113#issuecomment-662160847
> > Doesn't a SCP trigger log splitting (and therefore recoverLease) which would handle this case? > > That's my point. We don't have the SCP because the proc wals were deleted. We normally do an SCP when we receive the RS ephemeral node deletion in ZK. Since we don't have either of these, we just have to be super sure that it's actually safe to submit that SCP. I agree with you if that we did submit an SCP, the system _should_ recover. > > This makes me wonder... do we have any analogous situations in a "normal" cluster (with hardware). For example.. > > 1. I have a healthy cluster (1 master, many RS) > > 2. I stop the master > > 3. I kill one RS > 3a. I do not restart that RS > > 4. I restart the master > > > Do we submit an SCP for that RS today? Or, only when the new instance of that RS is started? I think this is a comparable situation -- maybe there's something I've not considered that we can still pull "state" from (e.g. we store something in the proc wals) Wouldn't there still be a znode in this case? That would probably trigger a SCP. Maybe you would get that situation if you added a 3b. delete zNode/clear out ZK ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
