ndimiduk commented on a change in pull request #2034:
URL: https://github.com/apache/hbase/pull/2034#discussion_r459047138
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
##########
@@ -85,6 +90,12 @@ public void sync(boolean forceSync) throws IOException {
} else {
fsdos.hflush();
}
+ AtomicUtils.updateMax(this.syncedLength, fsdos.getPos());
Review comment:
@Apache9 I read your later comments about keeping `AtomicUtils` because
the built-in `AtomicLong` does not provide the short-circuit semantics you have
implemented there. Sorry, I cannot find that thread to reply there. I dug
around and don't see any intrinsics in the JVM that would implement this for
us, so I agree with keeping our implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
