virajjasani commented on a change in pull request #2132:
URL: https://github.com/apache/hbase/pull/2132#discussion_r460052849
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserAggregateFactory.java
##########
@@ -28,7 +28,7 @@ private MetricsUserAggregateFactory() {
}
public static final String METRIC_USER_ENABLED_CONF =
"hbase.regionserver.user.metrics.enabled";
- public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = true;
+ public static final boolean DEFAULT_METRIC_USER_ENABLED_CONF = false;
Review comment:
We have many default constants for multiple configs defined in core
code, seems like we are not utilizing hbase-default.xml.
@saintstack it's not related to this PR, but should we have a general
guideline to keep config's default values only in `hbase-default.xml` and not
in code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
