cuibo01 commented on a change in pull request #2084:
URL: https://github.com/apache/hbase/pull/2084#discussion_r460476970
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java
##########
@@ -426,6 +439,9 @@ private void prepareLogReplay(final MasterProcedureEnv env,
final Set<HRegionInf
MasterFileSystem mfs = env.getMasterServices().getMasterFileSystem();
AssignmentManager am = env.getMasterServices().getAssignmentManager();
mfs.prepareLogReplay(this.serverName, regions);
+ // If the master doesn't fail, we'll set this again in SERVER_CRASH_ASSIGN
+ // can we skip doing it here? depends on how fast another observer
+ // needs to see that things were processed since we yield between now and
then.
Review comment:
the comment from your patch...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
