busbey opened a new pull request #2174:
URL: https://github.com/apache/hbase/pull/2174


   with just the new test, things fail after spinning until timeout
   ```
   13:40:17 [INFO] -------------------------------------------------------
   13:40:17 [INFO]  T E S T S
   13:40:17 [INFO] -------------------------------------------------------
   13:40:18 [INFO] Running org.apache.hadoop.hbase.regionserver.TestHRegion
   13:54:30 [ERROR] Tests run: 104, Failures: 0, Errors: 1, Skipped: 0, Time 
elapsed: 780.658 s <<< FAILURE! - in 
org.apache.hadoop.hbase.regionserver.TestHRegion
   13:54:30 [ERROR] org.apache.hadoop.hbase.regionserver.TestHRegion  Time 
elapsed: 586.556 s  <<< ERROR!
   org.junit.runners.model.TestTimedOutException: test timed out after 780 
seconds
        at 
org.apache.hadoop.hbase.regionserver.TestHRegion.testBatchMutateWithZeroRowLockWait(TestHRegion.java:6488)
   ```
   
   warning for those looking to duplicate this, there are about 2.5 million 
copies of this message
   ```
   MacBook-Air:hbase busbey$ grep -A 30 "Failed getting lock, row=a" 
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.TestHRegion-output.txt
 | head -n 31
   2020-07-29 13:43:32,802 WARN  [Time-limited test] 
regionserver.HRegion$BatchOperation(3501): Failed getting lock, row=a, in 
region 
org.apache.hadoop.hbase.regionserver.HRegion$MutationBatchOperation@3546487c
   java.io.IOException: Timed out waiting for lock for row: a in region 
9368508e4300a0030fbbdf19cc7e1fcd
        at 
org.apache.hadoop.hbase.regionserver.HRegion.getRowLockInternal(HRegion.java:6151)
        at 
org.apache.hadoop.hbase.regionserver.HRegion$BatchOperation.lockRowsAndBuildMiniBatch(HRegion.java:3493)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.doMiniBatchMutate(HRegion.java:4194)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4164)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4095)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4086)
        at 
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4100)
        at 
org.apache.hadoop.hbase.regionserver.TestHRegion.testBatchMutateWithZeroRowLockWait(TestHRegion.java:6488)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
        at 
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
   ```
   and it takes a bit of room
   ```
   MacBook-Air:hbase busbey$ ls -lah 
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.TestHRegion-output.txt
 
   -rw-r--r--  1 busbey  staff   7.7G Jul 29 13:55 
hbase-server/target/surefire-reports/org.apache.hadoop.hbase.regionserver.TestHRegion-output.txt
   ```
   
   test passes after this patch is in place, verified presence of warning in 
test logs. test-only backport to branch-1.3 also passes without the HRegion 
change.
   
   tested out a branch-2.1 based backport on a cluster and that also worked as 
expected (logged a warning and then writes to meta were able to succeed)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to