[
https://issues.apache.org/jira/browse/HBASE-5444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266167#comment-13266167
]
[email protected] commented on HBASE-5444:
------------------------------------------------------
bq. On 2012-05-01 20:20:09, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/HConstants.java, line 679
bq. > <https://reviews.apache.org/r/4463/diff/4/?file=105802#file105802line679>
bq. >
bq. > Were you going to move this down to where its used G? Does it need
to be up here?
I can just get rid of this and use null everywhere. That's what it looks like
Jimmy did.
bq. On 2012-05-01 20:20:09, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java,
line 173
bq. > <https://reviews.apache.org/r/4463/diff/4/?file=105817#file105817line173>
bq. >
bq. > We should not be reaching over into the master package. Put this
protocol class at the top level since shared by master and regionserver?
Will do.
bq. On 2012-05-01 20:20:09, Michael Stack wrote:
bq. > src/main/java/org/apache/hadoop/hbase/master/MXBean.java, line 23
bq. > <https://reviews.apache.org/r/4463/diff/4/?file=105809#file105809line23>
bq. >
bq. > All of these classes are importing generated pb classes. Would it
be better to have a high-level ServerLoad class that hid inside it the pb stuff
instead? Less pb generated class pollution.
I think that's a good idea. I was considering doing that, but wasn't sure if I
should do it for all the generated pb types. Since ServerLoad is sprinkled
everywhere, it seems like that is at least a good place to start.
- Gregory
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4463/#review7442
-----------------------------------------------------------
On 2012-05-01 19:53:51, Gregory Chanan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4463/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-01 19:53:51)
bq.
bq.
bq. Review request for hbase and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adds PB-based calls replacing HMasterRegionInterface.
bq.
bq. There are some temporary hacks, e.g. converting PB-based ServerLoad to
existing HServerLoad so I didn't need to convert ClusterStatus (which brings in
a lot of other changes). That will be cleaned up in HBASE-5445.
bq.
bq.
bq. This addresses bug HBASE-5444.
bq. https://issues.apache.org/jira/browse/HBASE-5444
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java a9d80a0
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 0db2760
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 973c7cb
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java
fd97830
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java bb6ab3b
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
f56127d
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 81e9023
bq. src/main/java/org/apache/hadoop/hbase/master/MXBean.java 7f44dc2
bq. src/main/java/org/apache/hadoop/hbase/master/MXBeanImpl.java 45b8fe7
bq. src/main/java/org/apache/hadoop/hbase/master/MasterDumpServlet.java
be63838
bq.
src/main/java/org/apache/hadoop/hbase/master/RegionServerStatusProtocol.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 80271b1
bq. src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 994cb76
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
efcf74d
bq. src/main/java/org/apache/hadoop/hbase/ClusterStatus.java 5d7f07b
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
69434f7
bq.
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
3c7c091
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RegionServerStatusProtos.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
ebffad6
bq. src/main/protobuf/RegionServerStatus.proto PRE-CREATION
bq. src/main/protobuf/hbase.proto 12e6053
bq. src/main/resources/hbase-webapps/master/table.jsp 3ef1190
bq. src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 72554cb
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
d039be3
bq. src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
36046f8
bq. src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java bd5fa90
bq. src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
f8029ba
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
e99d251
bq.
bq. Diff: https://reviews.apache.org/r/4463/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran jenkins job, all unit tests passed.
bq.
bq.
bq. Thanks,
bq.
bq. Gregory
bq.
bq.
> Add PB-based calls to HMasterRegionInterface
> --------------------------------------------
>
> Key: HBASE-5444
> URL: https://issues.apache.org/jira/browse/HBASE-5444
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Todd Lipcon
> Assignee: Gregory Chanan
> Attachments: HBASE-5444-v6-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
