virajjasani commented on a change in pull request #2172:
URL: https://github.com/apache/hbase/pull/2172#discussion_r463671614
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover1.java
##########
@@ -80,23 +83,18 @@ public static void tearDownAfterClass() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
- @Before
- public void setUp() throws Exception {
- // Create a pre-split table just to populate some regions
- TableName tableName = TableName.valueOf("testRegionMover");
- Admin admin = TEST_UTIL.getAdmin();
- if (admin.tableExists(tableName)) {
- TEST_UTIL.deleteTable(tableName);
- }
+ private void initTableRegions(TableName tableName) throws IOException {
Review comment:
Oh, I wasn't aware of this. Sounds really great. I was also not happy to
keep repeating the same code for each method.
Thanks, will update the PR shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]