virajjasani commented on a change in pull request #2042:
URL: https://github.com/apache/hbase/pull/2042#discussion_r463768549



##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -765,40 +767,45 @@
 %>
 </table>
 <h2>Table Schema</h2>
+
 <table class="table table-striped">
+<%
+  Collection<HColumnDescriptor> families = new 
HTableDescriptor(table.getDescriptor()).getFamilies();
+  Set<Bytes> familyKeySet = new HashSet();

Review comment:
       nit: `HashSet<>()`

##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -765,40 +767,45 @@
 %>
 </table>
 <h2>Table Schema</h2>
+
 <table class="table table-striped">
+<%
+  Collection<HColumnDescriptor> families = new 
HTableDescriptor(table.getDescriptor()).getFamilies();

Review comment:
       Please use `ModifyableTableDescriptor` as `HTableDescriptor` is 
deprecated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to