[
https://issues.apache.org/jira/browse/HBASE-24695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169451#comment-17169451
]
Hudson commented on HBASE-24695:
--------------------------------
Results for branch branch-2
[build #2765 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2765/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2765/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2760//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2758/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> FSHLog - close the current WAL file in a background thread
> ----------------------------------------------------------
>
> Key: HBASE-24695
> URL: https://issues.apache.org/jira/browse/HBASE-24695
> Project: HBase
> Issue Type: Improvement
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> We have this as a TODO in code already
> {code}
> // It is at the safe point. Swap out writer from under the blocked writer
> thread.
> // TODO: This is close is inline with critical section. Should happen
> in background?
> if (this.writer != null) {
> oldFileLen = this.writer.getLength();
> try {
> TraceUtil.addTimelineAnnotation("closing writer");
> this.writer.close();
> TraceUtil.addTimelineAnnotation("writer closed");
> this.closeErrorCount.set(0);
> }
> {code}
> This close call in critical section and writes are blocked. Lets move this
> close call into another WALCloser thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
