virajjasani commented on a change in pull request #2196:
URL: https://github.com/apache/hbase/pull/2196#discussion_r466317865
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java
##########
@@ -200,70 +201,7 @@ public static ThreadPoolExecutor
getBoundedCachedThreadPool(
public static ThreadPoolExecutor getBoundedCachedThreadPool(int
maxCachedThread, long timeout,
Review comment:
Agree, at least for now, let me make callers use
`getBoundedCachedThreadPool` with `ThreadFactoryBuilder` input and only keep
that version of `getBoundedCachedThreadPool` in Threads class.
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/procedure/SimpleRSProcedureManager.java
##########
@@ -125,9 +125,8 @@ public Subprocedure buildSubprocedure(String name, byte[]
data) {
public SimpleSubprocedurePool(String name, Configuration conf) {
this.name = name;
- executor = new ThreadPoolExecutor(1, 1, 500,
- TimeUnit.SECONDS, new LinkedBlockingQueue<>(),
- Threads.newDaemonThreadFactory("rs(" + name + ")-procedure"));
+ executor = new ThreadPoolExecutor(1, 1, 500, TimeUnit.SECONDS, new
LinkedBlockingQueue<>(),
Review comment:
Wow, 500s of keep-alive, Thanks, quite a catch. This indeed should
belong to SingleThreadExecutor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
