nyl3532016 commented on a change in pull request #2206:
URL: https://github.com/apache/hbase/pull/2206#discussion_r466377751



##########
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
##########
@@ -178,7 +179,7 @@ private void scheduleRelogin(Throwable error) {
     RELOGIN_EXECUTOR.schedule(() -> {
       try {
         provider.relogin();
-      } catch (IOException e) {
+      } catch (Throwable e) {

Review comment:
       I think other parts catching only IOException is just fine, the 
uncatched exception will throw upward




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to