[ 
https://issues.apache.org/jira/browse/HBASE-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266342#comment-13266342
 ] 

Zhihong Yu commented on HBASE-5869:
-----------------------------------

According to 
https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/InvalidProtocolBufferException,
 InvalidProtocolBufferException doesn't provide its own method for revealing 
what went wrong during parsing.

In the patch, I see the following construct:
{code}
    } catch (InvalidProtocolBufferException e) {
      throw new DeserializationException(e);
{code}
I think we don't expect client to interpret InvalidProtocolBufferException. I 
would suggest changing the above to:
{code}
    } catch (InvalidProtocolBufferException e) {
      throw new DeserializationException(e.getMessage());
{code}
                
> Move SplitLogManager splitlog taskstate and AssignmentManager 
> RegionTransitionData znode datas to pb 
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5869
>                 URL: https://issues.apache.org/jira/browse/HBASE-5869
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: 5869v7.txt, 5869v8.txt, 5869v9.txt, firstcut.txt, 
> secondcut.txt, v10.txt, v11.txt, v12.txt, v13.txt, v4.txt, v5.txt, v6.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to