utf7 commented on pull request #2209: URL: https://github.com/apache/hbase/pull/2209#issuecomment-670585408
> Mind explaing a bit why we do not need the reflection any more? Because we have dropped the support for some hadoop versions? Thanks for reply I checkout the hadoop code with branch-2.7/branch-2.8/branch-2.9/branch-3/branch-3.0/branch-3.1/branch-3.2/branch-3.3 getCounter method just has two: `getCounter(Enum<?> counterName)` or `getCounter(String groupName, String counterName)` the code always pass two String params to invoke `getCounter(String,String)` , so I think we can just use getCounter(String,String) is good besides that: ihadoop 2 version has been removed from hbase 3.0 in jdk11 case: We need a minimum HDFS version of 3.2.0 for HADOOP-12760 So, I think we can safely to use getCounter(String,String) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
