joshelser commented on pull request #2193:
URL: https://github.com/apache/hbase/pull/2193#issuecomment-670613317
TestReplicationSource failure appears to be due to HBASE-24817 (#2198)
```
[INFO] Running
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource
[ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
49.293 s <<< FAILURE! - in
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource
[ERROR]
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testWALEntryFilter
Time elapsed: 1.641 s <<< FAILURE!
java.lang.AssertionError
at
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSource.testWALEntryFilter(TestReplicationSource.java:177)
```
We end up filtering out an edit because it's empty, but we expect to not
filter it because it's not a system table edit.
I'll make the same mocking changes to prevent future pain in
TestReplicationSource (like I did for TestWALEntryStream) in a follow-on, as
well as fix this test. FYI @saintstack
Pushing this to make some progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
