bitoffdev commented on a change in pull request #2232:
URL: https://github.com/apache/hbase/pull/2232#discussion_r468065553
##########
File path: hbase-shell/src/test/ruby/shell/shell_test.rb
##########
@@ -123,14 +124,35 @@ class FooC; end
# check that at least one of the HBase constants is present while
evaluating
io = StringIO.new <<~EOF
- ROWPREFIXFILTER
+ ROWPREFIXFILTER.dump
EOF
output = capture_stdout { @shell.eval_io(io) }
assert_match(/"ROWPREFIXFILTER"/, output)
end
#-----------------------------------------------------------------------------
+ define_test 'Shell::Shell#exception_handler should hide traceback' do
+ class TestException < RuntimeError; end
+ hide_traceback = true
Review comment:
Agreed. I removed the unused variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
