ndimiduk commented on a change in pull request #2215:
URL: https://github.com/apache/hbase/pull/2215#discussion_r468088533
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##########
@@ -2293,6 +2293,13 @@ public static TableName
toTableName(HBaseProtos.TableName tableNamePB) {
.setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier())).build();
}
+ public static List<HBaseProtos.TableName>
toProtoTableNameList(List<TableName> tableNameList) {
+ if (tableNameList == null) {
+ return new ArrayList<>();
Review comment:
`emptyList` returns a non-modifiable collection. The other methods here
follow this pattern of returning a modifiable list. I haven't evaluated all the
call-sites to see if `emptyList` would be acceptable. Even if not, probably
these `ArrayLists` should be replaced with `LinkedList`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
