infraio commented on a change in pull request #2064:
URL: https://github.com/apache/hbase/pull/2064#discussion_r468269188
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -130,8 +137,6 @@
protected final ConcurrentHashMap<String, ReplicationSourceShipper>
workerThreads =
new ConcurrentHashMap<>();
- private AtomicLong totalBufferUsed;
Review comment:
Good idea. Let me refator it. And after I rethink about this, the
ReplicationSourceManager is still needed by ReplicationSource. But only need
the getTotalBuffered/getTotalLimit/getGlobalMetrics now. Maybe introduce a new
interface in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
