bsglz commented on a change in pull request #2202:
URL: https://github.com/apache/hbase/pull/2202#discussion_r468346230



##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -219,6 +219,12 @@ message RollWALWriterResponse {
   repeated bytes region_to_flush = 1;
 }
 
+message ArchiveWALRequest {

Review comment:
       Checked the existing api in Admin.java, such as flushRegion, 
compactRegion, seems currently we dont use status, if there is something wrong 
at server side, we notice client by throw ServiceException. 
   Though the FlushRegionResponse has a flushed flag, but does not be used at 
client.
   Maybe we should keep consist?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to