ndimiduk commented on a change in pull request #2215:
URL: https://github.com/apache/hbase/pull/2215#discussion_r468929247
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##########
@@ -3279,13 +3279,22 @@ private void getProcedureResult(long procId,
CompletableFuture<Void> future, int
@Override
public CompletableFuture<Boolean> normalize() {
+ return normalize(RequestConverter.buildNormalizeRequest());
+ }
+
+ @Override
+ public CompletableFuture<Boolean> normalize(NormalizeTableFilterParams ntfp)
{
+ return normalize(RequestConverter.buildNormalizeRequest(ntfp));
+ }
+
+ private CompletableFuture<Boolean> normalize(NormalizeRequest request) {
return this
- .<Boolean> newMasterCaller()
- .action(
- (controller, stub) -> this.<NormalizeRequest, NormalizeResponse,
Boolean> call(
- controller, stub, RequestConverter.buildNormalizeRequest(),
- (s, c, req, done) -> s.normalize(c, req, done), (resp) ->
resp.getNormalizerRan()))
- .call();
+ .<Boolean> newMasterCaller()
+ .action(
+ (controller, stub) -> this.<NormalizeRequest, NormalizeResponse,
Boolean> call(
Review comment:
The params on `call` can be elided but the param on `newMasterCaller()`
is mandatory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
