virajjasani commented on a change in pull request #2239:
URL: https://github.com/apache/hbase/pull/2239#discussion_r469131166
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java
##########
@@ -692,12 +692,12 @@ public void
interruptedExceptionNoThrow(InterruptedException ie, boolean throwLa
*/
@Override
public void close() {
- zkEventProcessor.shutdownNow();
try {
recoverableZooKeeper.close();
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
Review comment:
oh wait, can we put `shutdownNow()` to `finally` block? Even without
that it should be executed but just in case in future, more Exception handling
might be lined up or if ZK client close throws some runtime exception, at least
we will perform shutdown of threadpool in finally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
