wchevreuil commented on a change in pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#discussion_r469394487
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java
##########
@@ -309,6 +310,16 @@ public WALEntryBatch poll(long timeout) throws
InterruptedException {
return entryBatchQueue.poll(timeout, TimeUnit.MILLISECONDS);
}
+ public void clearWALEntryBatch() {
Review comment:
> We are only calling it from ReplicationSource.terminate (see line
#606), after we certify that neither the shipper, nor the reader threads are
alive anymore
Actually, we could move that check to clearWALEntryBatch method itself, and
since shipper has a reference to reader, but not the other way around, we can
move it to shipper, instead? Let me give it a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
