[ 
https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zheng Wang updated HBASE-24875:
-------------------------------
    Description: 
The description of unassign in Admin.java shows below, it is not true, in fact, 
we just close the region now, also we do not need the force param any more.
{code:java}
/**
 * Unassign a region from current hosting regionserver.  Region will then be 
assigned to a
 * regionserver chosen at random.  Region could be reassigned back to the same 
server.  Use {@link
 * #move(byte[], ServerName)} if you want to control the region movement.
 *
 * @param regionName Region to unassign. Will clear any existing RegionPlan if 
one found.
 * @param force If <code>true</code>, force unassign (Will remove region from 
regions-in-transition too if
 * present. If results in double assignment use hbck -fix to resolve. To be 
used by experts).
 * @throws IOException if a remote or network exception occurs
 */
void unassign(byte[] regionName, boolean force)
    throws IOException;
{code}

  was:
The describe of unassign in Admin.java shows below, it is not true, in fact, we 
just close the region now, also we do not need the force param any more.
{code:java}
/**
 * Unassign a region from current hosting regionserver.  Region will then be 
assigned to a
 * regionserver chosen at random.  Region could be reassigned back to the same 
server.  Use {@link
 * #move(byte[], ServerName)} if you want to control the region movement.
 *
 * @param regionName Region to unassign. Will clear any existing RegionPlan if 
one found.
 * @param force If <code>true</code>, force unassign (Will remove region from 
regions-in-transition too if
 * present. If results in double assignment use hbck -fix to resolve. To be 
used by experts).
 * @throws IOException if a remote or network exception occurs
 */
void unassign(byte[] regionName, boolean force)
    throws IOException;
{code}


> The describe and param for unassign not correct since the implementation 
> changed at server side
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-24875
>                 URL: https://issues.apache.org/jira/browse/HBASE-24875
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Zheng Wang
>            Assignee: Zheng Wang
>            Priority: Major
>
> The description of unassign in Admin.java shows below, it is not true, in 
> fact, we just close the region now, also we do not need the force param any 
> more.
> {code:java}
> /**
>  * Unassign a region from current hosting regionserver.  Region will then be 
> assigned to a
>  * regionserver chosen at random.  Region could be reassigned back to the 
> same server.  Use {@link
>  * #move(byte[], ServerName)} if you want to control the region movement.
>  *
>  * @param regionName Region to unassign. Will clear any existing RegionPlan 
> if one found.
>  * @param force If <code>true</code>, force unassign (Will remove region from 
> regions-in-transition too if
>  * present. If results in double assignment use hbck -fix to resolve. To be 
> used by experts).
>  * @throws IOException if a remote or network exception occurs
>  */
> void unassign(byte[] regionName, boolean force)
>     throws IOException;
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to